feat(tenant): add optional userId/loginId actor to generateSSOConfigurationLink#740
Conversation
…rationLink When provided, the SSO Setup Suite session is attributed to that real user (who must exist and belong to the tenant) so actions taken inside the suite are audited against them instead of a temporary user. userId takes precedence over loginId. Backward compatible (trailing optional params). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment prioritizes contributors who recently modified the same files (tenant.test.ts and tenant.ts) to ensure familiarity with the latest changes and testing considerations, while also including a contributor from README.md to cover documentation updates.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Adds optional trailing userId/loginId params to generateSSOConfigurationLink, attributing the SSO Suite session to a real user.
No issues found — good bones! The new params follow the existing optional-param pattern (ssoId/email/templateId), the request body stays consistent, and there's a matching unit test + README example. No other call sites or type defs need updating. Woof!
…erateSSOConfigurationLink The SSO Setup Suite link now takes an optional actorId that is recorded as-is as the audit actor for in-suite actions (no user lookup/validation). Replaces the previous userId/loginId params. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@shuni re-review |
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds optional trailing userId/loginId params to generateSSOConfigurationLink, attributing the SSO Suite session to a real user.
No issues found — good bones! The new params follow the existing optional-param pattern (ssoId/email/templateId), the request body stays consistent, and there's a matching unit test + README example. No other call sites or type defs need updating. Woof!
2 participants
Description
management.tenant.generateSSOConfigurationLinknow accepts optional trailinguserIdandloginIdparams. When provided, the SSO Setup Suite session is attributed to that real user (who must exist and belong to the tenant) so actions performed inside the suite are audited against them instead of the temporary user.userIdtakes precedence overloginId; omitting them preserves existing behavior.Pairs with the backend change: descope/backend#1335 (resolves descope/etc#16281).
Changes
userId/loginIdadded to the method signature and request body.